Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: block contact channel #33590

Merged
merged 32 commits into from
Oct 18, 2024
Merged

feat: block contact channel #33590

merged 32 commits into from
Oct 18, 2024

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Oct 15, 2024 •
edited by jira bot
Loading

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

SCI-38

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 666dd02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 15, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33590/
on branch gh-pages at 2024-10-18 00:28 UTC

@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.39%. Comparing base (b923f2d) to head (666dd02).
Report is 5 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feat/single-contact-id   #33590      +/-   ##
==========================================================
- Coverage                   74.91%   74.39%   -0.53%     
==========================================================
  Files                         470      471       +1     
  Lines                       20727    20921     +194     
  Branches                     5289     5344      +55     
==========================================================
+ Hits                        15528    15564      +36     
- Misses                       4579     4721     +142     
- Partials                      620      636      +16

@tapiarafael tapiarafael marked this pull request as ready for review October 15, 2024 23:55
@tapiarafael tapiarafael requested review from a team as code owners October 15, 2024 23:55
@tapiarafael tapiarafael requested a review from a team as a code owner October 16, 2024 18:38
KevLehman
KevLehman previously approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope CI passes :)

matheusbsilva137
matheusbsilva137 reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@matheusbsilva137 matheusbsilva137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we missing a changeset here? 👀

MarcosSpessatto
MarcosSpessatto requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we have a test breaking here, probably due to license changes

@tapiarafael tapiarafael added this to the 7.0 milestone Oct 17, 2024
@pierre-lehnen-rc pierre-lehnen-rc changed the base branch from develop to feat/single-contact-id October 17, 2024 19:49
@pierre-lehnen-rc pierre-lehnen-rc merged commit b47fb3c into feat/single-contact-id Oct 18, 2024
43 of 48 checks passed
@pierre-lehnen-rc pierre-lehnen-rc deleted the feat/contact-blocking branch October 18, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheusbsilva137 matheusbsilva137 matheusbsilva137 left review comments

@MarcosSpessatto MarcosSpessatto MarcosSpessatto requested changes

@KevLehman KevLehman KevLehman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tapiarafael @KevLehman @MarcosSpessatto @matheusbsilva137 @pierre-lehnen-rc